Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#103] Provide a generic class on search input #111

Merged
1 commit merged into from
Aug 24, 2016
Merged

[#103] Provide a generic class on search input #111

1 commit merged into from
Aug 24, 2016

Conversation

camlafit
Copy link
Contributor

@camlafit camlafit commented Apr 8, 2016

  • Set a style on input search following theme style

Fixes #103

* Set a style on input search following theme style
* Solves #103
@camlafit
Copy link
Contributor Author

Hi

Any news about this suggestion and new version was provided. Can you merge it @toupeira ?

@elbenfreund
Copy link
Contributor

@border0464111 If you got time, can you have a look at this please? Looks alright.

@elbenfreund elbenfreund assigned ghost Aug 17, 2016
@elbenfreund elbenfreund changed the title Provide a generic class on search input [#103] Provide a generic class on search input Aug 19, 2016
@ghost
Copy link

ghost commented Aug 22, 2016

Tested, all good for me too :D

@elbenfreund
Copy link
Contributor

@border0464111 Feel free to merge! :)

@camlafit
Copy link
Contributor Author

camlafit commented Aug 23, 2016 via email

@elbenfreund
Copy link
Contributor

If boarder does not have time today I will merge it by evening. But in general I would like him to do this as he is taking over as maintainer of the extension :)

Thank you for the commit! You don't happen to be interested in joining our little hamster crew are you? :)

@camlafit
Copy link
Contributor Author

camlafit commented Aug 23, 2016 via email

@elbenfreund
Copy link
Contributor

elbenfreund commented Aug 23, 2016

@camlafit While integration with other time tracking services is part of our mid/long term goals I would not expect them to be ready this year :(
Right now our focus is on bringing the project in shape in general. As we are revisiting a lot of the codebase, the most valuable thing right now is another set of eyes for code reviews. So if you feel like joining us, please let me know.

@ghost ghost merged commit 492fb08 into projecthamster:master Aug 24, 2016
@elbenfreund
Copy link
Contributor

@camlafit
I just stumbled upon hamster-bridge. Maybe this is of some use for you?

@camlafit
Copy link
Contributor Author

Hi

yes hamster-bridge looks interesting, I've found an another project with same purpose.

But i come about an other pb :) I've updated extensions from https://extensions.gnome.org and last updates are not presents (as this PR). Is it normal ? I don't know how gnome.org provide update.

@elbenfreund
Copy link
Contributor

elbenfreund commented Oct 13, 2016

The current development branch has not been packaged to be placed on éxtensions.gnome.org.
I would like to get this wrapped up in the near future but this depends a bit on @border0464111 who is officially maintaining the extension and should look over a couple of open pull requests before we can package a new release. As a workaround you should however be able to symlink the repository directly into the extension dir.

Please Frederic, if you get this let me know what your timeline / available resources are the next few weeks so we can plan around what is and what is not possible.

btw: @camlafit can you please point me towards 'the other project' that you mentioned.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants